Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hz): template param change #716

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix(hz): template param change #716

merged 3 commits into from
Jul 20, 2023

Conversation

StellarisW
Copy link
Member

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: params in generator.RegisterInfo changed, so params name in template need change too
zh(optional):

(Optional) Which issue(s) this PR fixes:

@StellarisW StellarisW requested review from a team as code owners July 14, 2023 12:08
@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 3:37am

@FGYFFFF
Copy link
Contributor

FGYFFFF commented Jul 17, 2023

感谢,没啥问题。 英文版是否可以一起修改下?

Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@li-jin-gou li-jin-gou merged commit f40a128 into cloudwego:main Jul 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants