Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add key and desc field in hertz doc head #768

Merged
merged 8 commits into from
Aug 29, 2023

Conversation

chaoranz758
Copy link
Member

@chaoranz758 chaoranz758 commented Aug 25, 2023

What type of PR is this?

docs

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@chaoranz758 chaoranz758 requested review from a team as code owners August 25, 2023 07:34
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudwego ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 3:49am

@GuangmingLuo
Copy link
Member

@li-jin-gou @rogerogers Please help to review this PR

@li-jin-gou
Copy link
Member

英文和中文都修改一下

Copy link
Contributor

@rogerogers rogerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desc里有很多链接,会导致desc长度太长。

@li-jin-gou
Copy link
Member

看了一下问题都改了, @GuangmingLuo @rogerogers 再看下没什么问题先合进去吧

@GuangmingLuo GuangmingLuo merged commit 9edbe05 into cloudwego:main Aug 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants