Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link the English document to the official website #48

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

Skyenought
Copy link
Collaborator

What type of PR is this?

docs

What this PR does / why we need it (en: English/zh: Chinese):

en: link the English document to the official website
zh: 将英文文档链接指向官网

Which issue(s) this PR fixes:

@li-jin-gou
Copy link
Member

LGTM

GO111MODULE=on GOPROXY=https://goproxy.cn/,direct go get github.com/cloudwego/cwgo@latest

# Go 1.16 及以后版本

# Go version after using above than v1.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话不通


## Open Source License

cwgo has got Apache License2.0 licensing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cwgo is based on Apache License 2.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GET

@li-jin-gou
Copy link
Member

li-jin-gou commented Mar 13, 2023 via email

@GuangmingLuo
Copy link
Member

应该是之前的英文有问题,我将 文件名修改了之后这里出现了改变,其实只是加了 link 和默认英文了。

---Original--- From: "Guangming @.> Date: Mon, Mar 13, 2023 10:25 AM To: @.>; Cc: @.>;"State @.>; Subject: Re: [cloudwego/cwgo] docs: link the English document to the officialwebsite (PR #48) @GuangmingLuo commented on this pull request. In README.md: > GO111MODULE=on GOPROXY=https://goproxy.cn/,direct go get @.*** -# Go 1.16 及以后版本 + +# Go version after using above than v1.16 这句话不通 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

了解,可以单独提交个 PR 修复下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants