Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hertz_session #58

Merged
merged 13 commits into from
Dec 9, 2022
Merged

feat: add hertz_session #58

merged 13 commits into from
Dec 9, 2022

Conversation

justlorain
Copy link
Member

@justlorain justlorain commented Nov 26, 2022

What type of PR is this?

feat: A new feature

What this PR does / why we need it (English/Chinese):

en: Supplement the example demo using hertz-contrib/sessions redis-based distributed Session and hertz-contrib/csrf
zh: 补充使用hertz-contrib/sessions扩展基于redis的分布式Session和hertz-contrib/csrf拓展的示例demo

Which issue(s) this PR fixes:

null

@li-jin-gou li-jin-gou added the enhancement New feature or request label Nov 26, 2022
Copy link
Member

@li-jin-gou li-jin-gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this project would be better if it had a front end and we could use IDL to define the api interface.

@justlorain
Copy link
Member Author

justlorain commented Nov 26, 2022

I think this project would be better if it had a front end and we could use IDL to define the api interface.

got it, thx

@L2ncE
Copy link
Member

L2ncE commented Dec 9, 2022

Is it possible to add some comments to the key places?

@L2ncE
Copy link
Member

L2ncE commented Dec 9, 2022

Maybe it would be better to add a little bit introduction about redis-based distributed Session in the README.

@li-jin-gou
Copy link
Member

LGTM

@li-jin-gou li-jin-gou merged commit 7fc55ba into cloudwego:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants