Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not pre-bind for BindXXX interface & normalize content-type #1060

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

FGYFFFF
Copy link
Contributor

@FGYFFFF FGYFFFF commented Feb 4, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

使用BindXXX()接口时,无需做提前的 pre-bind;并且对 content-type 做归一化处理

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: do not pre-bind for BindXXX interface & normalize content-type
zh(optional): 使用BindXXX()接口时,无需做提前的 pre-bind;并且对 content-type 做归一化处理

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@FGYFFFF FGYFFFF requested review from a team as code owners February 4, 2024 07:08
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0619701) 82.52% compared to head (9a6d2f2) 82.54%.

Files Patch % Lines
pkg/app/context.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    82.52%   82.54%   +0.02%     
===========================================
  Files           98       98              
  Lines        10025    10026       +1     
===========================================
+ Hits          8273     8276       +3     
+ Misses        1255     1254       -1     
+ Partials       497      496       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FGYFFFF FGYFFFF merged commit c528e17 into develop Feb 19, 2024
26 of 28 checks passed
@FGYFFFF FGYFFFF deleted the fix/pre_bind branch February 19, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants