Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enrich ut for WithWriteTimeout in server/option.go #366

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

justlorain
Copy link
Member

What type of PR is this?

test: Adding missing tests or correcting existing tests

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

补充 server/option.go 中 WithWriteTimeout 的单元测试

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: enrich ut for WithWriteTimeout in server/option.go
zh(optional): 补充 server/option.go 中 WithWriteTimeout 的单元测试

Which issue(s) this PR fixes:

null

@li-jin-gou
Copy link
Member

LGTM

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 67.16% // Head: 67.19% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2549d4f) compared to base (8e3084b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #366      +/-   ##
===========================================
+ Coverage    67.16%   67.19%   +0.03%     
===========================================
  Files           89       89              
  Lines         8578     8578              
===========================================
+ Hits          5761     5764       +3     
+ Misses        2456     2454       -2     
+ Partials       361      360       -1     
Impacted Files Coverage Δ
pkg/common/compress/compress.go 79.04% <0.00%> (-4.77%) ⬇️
pkg/app/server/option.go 96.74% <0.00%> (+3.25%) ⬆️
pkg/common/timer/timer.go 80.95% <0.00%> (+19.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants