Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more metadata related APIs to RequestContext #375

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

justlorain
Copy link
Member

What type of PR is this?

feat: A new feature

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

补充常用的Get***函数

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Supplement usual Get function
zh(optional): 补充常用的Get***函数

Which issue(s) this PR fixes:

Fixes #368

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 67.21% // Head: 67.32% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (90c4a27) compared to base (efde5b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #375      +/-   ##
===========================================
+ Coverage    67.21%   67.32%   +0.11%     
===========================================
  Files           89       89              
  Lines         8573     8593      +20     
===========================================
+ Hits          5762     5785      +23     
+ Misses        2450     2447       -3     
  Partials       361      361              
Impacted Files Coverage Δ
pkg/app/context.go 68.79% <100.00%> (+1.43%) ⬆️
pkg/common/compress/compress.go 83.80% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@welkeyever welkeyever changed the title feat: Supplement usual Get function feat: add more metadata related APIs to RequestContext Nov 15, 2022
@li-jin-gou li-jin-gou merged commit aa5b0d8 into cloudwego:develop Nov 15, 2022
@li-jin-gou li-jin-gou mentioned this pull request Nov 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

恳请context里面加个GetUint64(key string)方法
3 participants