Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Cookies function to return all the request cookies #495

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

justlorain
Copy link
Member

@justlorain justlorain commented Dec 27, 2022

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

添加 Cookies 方法

(Optional) More detail description for this PR(en: English/zh: Chinese).

en: Cookies returns all the request cookies
zh(optional): Cookies 返回所有的请求 Cookie

Which issue(s) this PR fixes:

null

@justlorain justlorain requested review from a team as code owners December 27, 2022 08:18
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 69.34% // Head: 69.65% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (8d3dfca) compared to base (81332e6).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8d3dfca differs from pull request most recent head 48f752b. Consider uploading reports for the commit 48f752b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #495      +/-   ##
===========================================
+ Coverage    69.34%   69.65%   +0.31%     
===========================================
  Files           93       93              
  Lines         8874     8843      -31     
===========================================
+ Hits          6154     6160       +6     
+ Misses        2355     2319      -36     
+ Partials       365      364       -1     
Impacted Files Coverage Δ
pkg/protocol/header.go 75.59% <100.00%> (+0.65%) ⬆️
pkg/common/adaptor/request.go 80.00% <0.00%> (-0.96%) ⬇️
pkg/common/config/option.go 100.00% <0.00%> (ø)
pkg/common/errors/errors.go 87.95% <0.00%> (ø)
pkg/network/netpoll/transport.go 0.00% <0.00%> (ø)
pkg/protocol/cookie.go 88.47% <0.00%> (+2.05%) ⬆️
pkg/route/engine.go 63.19% <0.00%> (+2.64%) ⬆️
pkg/app/server/option.go 98.55% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/app/context.go Outdated Show resolved Hide resolved
pkg/app/context_test.go Outdated Show resolved Hide resolved
pkg/app/context.go Outdated Show resolved Hide resolved
@FGYFFFF
Copy link
Contributor

FGYFFFF commented Dec 27, 2022

Can the title be more detailed?

@justlorain justlorain changed the title feat: add cookies feat: add Cookies function to return all the request cookies Dec 27, 2022
Duslia
Duslia previously approved these changes Dec 27, 2022
welkeyever
welkeyever previously approved these changes Dec 29, 2022
Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

Duslia
Duslia previously approved these changes Dec 29, 2022
@welkeyever welkeyever enabled auto-merge (squash) December 29, 2022 13:27
@Duslia Duslia dismissed stale reviews from welkeyever and themself via 48f752b January 4, 2023 08:38
@welkeyever welkeyever merged commit 855e03d into cloudwego:develop Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants