Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http1): remove duplicated code #817

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Jun 16, 2023

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>.
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo.

(Optional) Translate the PR title into Chinese.

删除重复代码

(Optional) More detail description for this PR(en: English/zh: Chinese).

en:
Remove the duplicated code from https://github.com/cloudwego/hertz/blob/develop/pkg/protocol/http1/server.go#L328-L332
zh(optional):
删除和 https://github.com/cloudwego/hertz/blob/develop/pkg/protocol/http1/server.go#L328-L332 重复的代码

(Optional) Which issue(s) this PR fixes:

related to #804 (comment)

(Optional) The PR that updates user documentation:

@a631807682 a631807682 requested review from a team as code owners June 16, 2023 08:51
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (f4f193d) 75.70% compared to head (1018fc4) 75.68%.

❗ Current head 1018fc4 differs from pull request most recent head a9170ee. Consider uploading reports for the commit a9170ee to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #817      +/-   ##
===========================================
- Coverage    75.70%   75.68%   -0.02%     
===========================================
  Files           97       97              
  Lines         9495     9492       -3     
===========================================
- Hits          7188     7184       -4     
- Misses        1857     1858       +1     
  Partials       450      450              
Impacted Files Coverage Δ
pkg/protocol/http1/server.go 63.59% <ø> (+0.91%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou
Copy link
Member

thanks

@welkeyever welkeyever changed the title refactor(http1): remove duplicated code chore(http1): remove duplicated code Jul 17, 2023
@welkeyever welkeyever merged commit 2bd70be into cloudwego:develop Jul 17, 2023
12 of 13 checks passed
@a631807682 a631807682 deleted the refactor_rm_dup_code branch July 17, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants