Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Del func for requestHeader #950

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

chaoranz758
Copy link
Member

@chaoranz758 chaoranz758 commented Sep 18, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

requestHeader 中添加 Del 函数,与 responseHeader 保持一致

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: feat: add Del func for requestHeader
zh(optional): feat: requestHeader 中添加 Del 函数

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

#946

@chaoranz758 chaoranz758 requested review from a team as code owners September 18, 2023 11:44
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d21a04a) 81.98% compared to head (1253389) 81.99%.

❗ Current head 1253389 differs from pull request most recent head ae1d003. Consider uploading reports for the commit ae1d003 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #950   +/-   ##
========================================
  Coverage    81.98%   81.99%           
========================================
  Files           97       97           
  Lines         9625     9628    +3     
========================================
+ Hits          7891     7894    +3     
  Misses        1260     1260           
  Partials       474      474           
Files Changed Coverage Δ
pkg/protocol/header.go 78.15% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@li-jin-gou li-jin-gou merged commit c52e1c9 into cloudwego:develop Sep 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants