Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(thrift_multi_service): remove unnecessary files #128

Merged
merged 1 commit into from
May 15, 2024

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:


zh: 我们需要您为每个新的 example 添加 run.sh 与 test.sh 以便于用户运行和 CI 测试,如果您不知道如何添加,请参考其他 example 的 run.sh 与 test.sh 文件。

en: We need you to add run.sh and test.sh for each new example so that users can run and CI test. If you don't know how to add, please refer to the run.sh and test.sh files of other examples.

@Marina-Sakai Marina-Sakai requested review from a team as code owners May 15, 2024 05:48
@AsterDY AsterDY merged commit 9c9358b into cloudwego:main May 15, 2024
4 checks passed
@Marina-Sakai Marina-Sakai deleted the fix/remove_files branch May 15, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants