Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add nil check for MethodInfo which get from ServiceInfo in client.Call to ignore panic #1020

Merged
merged 1 commit into from Jul 10, 2023

Conversation

YangruiEmma
Copy link
Member

@YangruiEmma YangruiEmma commented Jul 7, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

optimize: 在 client.Call 对 MethodInfo 增加 nil 检查,避免 panic

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Normally, there will be no panic, but there are abnormal situations. Adding nil-check is convenient for troubleshooting
zh(optional): 正常不会出现 panic,但存在异常情况,增加 nil 检查便于问题排查

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@YangruiEmma YangruiEmma requested review from a team as code owners July 7, 2023 10:31
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (ab3c244) 68.01% compared to head (103430a) 68.12%.

❗ Current head 103430a differs from pull request most recent head 18c99d5. Consider uploading reports for the commit 18c99d5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1020      +/-   ##
===========================================
+ Coverage    68.01%   68.12%   +0.10%     
===========================================
  Files          248      248              
  Lines        18802    18810       +8     
===========================================
+ Hits         12789    12815      +26     
+ Misses        4845     4834      -11     
+ Partials      1168     1161       -7     
Impacted Files Coverage Δ
client/client.go 76.67% <100.00%> (+0.11%) ⬆️
pkg/loadbalance/weighted_round_robin.go 94.28% <100.00%> (+0.53%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

HeyJavaBean
HeyJavaBean previously approved these changes Jul 7, 2023
@YangruiEmma YangruiEmma merged commit 782e4ce into develop Jul 10, 2023
30 checks passed
@YangruiEmma YangruiEmma deleted the optimize/serviceInfo branch July 10, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants