Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): provide the ability to dynamically configure the rpctimeout config on the method hierarchy #1035

Merged
merged 3 commits into from Jul 25, 2023

Conversation

whalecold
Copy link
Member

@whalecold whalecold commented Jul 25, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

implement the rpcinfo.TimeoutProvider interface to provide the ability to dynamically configure the rpctimeout config on the method hierarchy

required by kitex-contrib/config-nacos#2

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@whalecold whalecold requested review from a team as code owners July 25, 2023 03:32
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2023

CLA assistant check
All committers have signed the CLA.

felix021
felix021 previously approved these changes Jul 25, 2023
@YangruiEmma
Copy link
Member

for pr title, it is suggested to say why need this change but not what the pr do

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13% 🎉

Comparison is base (5e4b9af) 67.88% compared to head (d8d380f) 68.02%.

❗ Current head d8d380f differs from pull request most recent head c0abded. Consider uploading reports for the commit c0abded to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1035      +/-   ##
===========================================
+ Coverage    67.88%   68.02%   +0.13%     
===========================================
  Files          249      249              
  Lines        18878    18900      +22     
===========================================
+ Hits         12816    12857      +41     
+ Misses        4884     4870      -14     
+ Partials      1178     1173       -5     
Files Changed Coverage Δ
pkg/rpctimeout/item_rpc_timeout.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whalecold whalecold changed the title feat(timeout): add the timeout provider implementation feat: provide the ability to dynamically configure the rpctimeout config on the method hierarchy Jul 25, 2023
@ppzqh
Copy link
Contributor

ppzqh commented Jul 25, 2023

Please fill in the "type" and more detailed description.

@whalecold
Copy link
Member Author

Please fill in the "type" and more detailed description.

Done.

@felix021 felix021 changed the title feat: provide the ability to dynamically configure the rpctimeout config on the method hierarchy feat(config): provide the ability to dynamically configure the rpctimeout config on the method hierarchy Jul 25, 2023
@felix021 felix021 merged commit b26b928 into cloudwego:develop Jul 25, 2023
16 checks passed
@whalecold whalecold deleted the feat/timeout branch July 25, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants