Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore SIGHUP when run with nohup #1055

Merged
merged 1 commit into from Aug 3, 2023

Conversation

joway
Copy link
Member

@joway joway commented Aug 3, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: https://stackoverflow.com/questions/64479821/why-hangup-signal-is-caught-even-with-nohup
zh(optional):

(Optional) Which issue(s) this PR fixes:

Fixes #1050

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners August 3, 2023 03:17
@joway joway enabled auto-merge (squash) August 3, 2023 03:20
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (4eff11b) 67.86% compared to head (011304c) 67.81%.

❗ Current head 011304c differs from pull request most recent head ce0cdf5. Consider uploading reports for the commit ce0cdf5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1055      +/-   ##
===========================================
- Coverage    67.86%   67.81%   -0.05%     
===========================================
  Files          252      252              
  Lines        18996    18999       +3     
===========================================
- Hits         12891    12885       -6     
- Misses        4924     4935      +11     
+ Partials      1181     1179       -2     
Files Changed Coverage Δ
internal/server/option.go 94.11% <100.00%> (+0.36%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joway joway merged commit 6a668e6 into cloudwego:develop Aug 3, 2023
16 checks passed
@joway joway deleted the fix/ignore-hup branch August 8, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

异常退出,没有详细信息
3 participants