Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: check header max size when ttheader encode #1064

Merged
merged 1 commit into from Aug 8, 2023

Conversation

joway
Copy link
Member

@joway joway commented Aug 8, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

optimise: ttheader 编码时候,检查 header 最大长度

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners August 8, 2023 03:44
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (a8510e4) 68.06% compared to head (de2012f) 68.08%.

❗ Current head de2012f differs from pull request most recent head 944ca92. Consider uploading reports for the commit 944ca92 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1064      +/-   ##
===========================================
+ Coverage    68.06%   68.08%   +0.01%     
===========================================
  Files          253      253              
  Lines        19072    19074       +2     
===========================================
+ Hits         12981    12986       +5     
+ Misses        4906     4901       -5     
- Partials      1185     1187       +2     
Files Changed Coverage Δ
pkg/remote/codec/header_codec.go 56.17% <0.00%> (-0.49%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joway joway enabled auto-merge (squash) August 8, 2023 03:54
@joway joway merged commit a83858a into cloudwego:develop Aug 8, 2023
16 checks passed
@joway joway deleted the optimise/check_header_size branch August 8, 2023 06:34
@HeyJavaBean HeyJavaBean changed the title optimise: check header max size when ttheader encode optimize: check header max size when ttheader encode Aug 14, 2023
jieqiboh pushed a commit to jieqiboh/kitex that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants