-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add heartbeat MessageType and processing logic for svrTransHandler #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1069 +/- ##
===========================================
- Coverage 69.09% 69.03% -0.07%
===========================================
Files 252 252
Lines 18813 18815 +2
===========================================
- Hits 12999 12988 -11
- Misses 4632 4639 +7
- Partials 1182 1188 +6
☔ View full report in Codecov by Sentry. |
felix021
reviewed
Aug 14, 2023
felix021
reviewed
Aug 14, 2023
DMwangnima
changed the title
feat: add heartbeat MessageType and processing logic for svrTrandHandler
feat: add heartbeat MessageType and processing logic for svrTransHandler
Aug 14, 2023
felix021
approved these changes
Aug 14, 2023
YangruiEmma
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: For implementing server-side Hessian2 codec heartbeat logic, we need to introduce Heartbeat MessageType. This heartbeat logic belongs to framework and user could not perceive it.
This change does not effect other codecs.
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: