Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add heartbeat MessageType and processing logic for svrTransHandler #1069

Merged
merged 5 commits into from
Aug 15, 2023

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

feat: For implementing server-side Hessian2 codec heartbeat logic, we need to introduce Heartbeat MessageType. This heartbeat logic belongs to framework and user could not perceive it.
This change does not effect other codecs.

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners August 14, 2023 07:44
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 61.11% and project coverage change: -0.07% ⚠️

Comparison is base (645fec2) 69.09% compared to head (133e44a) 69.03%.

❗ Current head 133e44a differs from pull request most recent head 4d44bb1. Consider uploading reports for the commit 4d44bb1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1069      +/-   ##
===========================================
- Coverage    69.09%   69.03%   -0.07%     
===========================================
  Files          252      252              
  Lines        18813    18815       +2     
===========================================
- Hits         12999    12988      -11     
- Misses        4632     4639       +7     
- Partials      1182     1188       +6     
Files Changed Coverage Δ
pkg/remote/message.go 88.03% <ø> (ø)
pkg/remote/trans/default_server_handler.go 74.59% <61.11%> (-1.23%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DMwangnima DMwangnima changed the title feat: add heartbeat MessageType and processing logic for svrTrandHandler feat: add heartbeat MessageType and processing logic for svrTransHandler Aug 14, 2023
@felix021 felix021 merged commit 88ea605 into cloudwego:develop Aug 15, 2023
16 checks passed
jieqiboh pushed a commit to jieqiboh/kitex that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants