Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(tool): support scaffold generation for hessian2 #1076

Merged
merged 6 commits into from
Oct 16, 2023
Merged

feature(tool): support scaffold generation for hessian2 #1076

merged 6 commits into from
Oct 16, 2023

Conversation

Lvnszn
Copy link
Contributor

@Lvnszn Lvnszn commented Aug 14, 2023 •
edited by felix021

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

支持生成 hessian2 的脚手架代码

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Lvnszn Lvnszn requested review from a team as code owners August 14, 2023 16:38
@Lvnszn Lvnszn force-pushed the feature_idl_for_hessian branch 4 times, most recently from 365b250 to fded1b2 Compare August 19, 2023 03:22
@Lvnszn Lvnszn force-pushed the feature_idl_for_hessian branch 2 times, most recently from ec53881 to 286bb5f Compare August 19, 2023 05:18
@Lvnszn Lvnszn changed the title [WIP] feature: 支持 hessian IDL 相关脚手架 feature: 支持 hessian IDL 相关脚手架 Aug 19, 2023
felix021
felix021 previously approved these changes Aug 19, 2023
View reviewed changes
felix021
felix021 previously approved these changes Aug 20, 2023
View reviewed changes
HeyJavaBean
HeyJavaBean reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@HeyJavaBean HeyJavaBean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还没 review 完，只看了一半

tool/internal_pkg/generator/generator.go Outdated Show resolved Hide resolved
tool/internal_pkg/pluginmode/protoc/plugin.go Outdated Show resolved Hide resolved
tool/internal_pkg/pluginmode/thriftgo/patcher.go Outdated Show resolved Hide resolved
@Lvnszn Lvnszn force-pushed the feature_idl_for_hessian branch 2 times, most recently from 6f9512b to 689e2ff Compare August 21, 2023 16:01
felix021
felix021 reviewed Aug 22, 2023
View reviewed changes
tool/internal_pkg/tpl/client.go Outdated Show resolved Hide resolved
internal/mocks/discovery/discovery.go Outdated Show resolved Hide resolved
@Lvnszn Lvnszn force-pushed the feature_idl_for_hessian branch 4 times, most recently from 44d733e to 996145c Compare September 24, 2023 15:07
HeyJavaBean
HeyJavaBean previously approved these changes Sep 25, 2023
View reviewed changes
tool/internal_pkg/pluginmode/thriftgo/struct_tpl.go Outdated Show resolved Hide resolved
tool/internal_pkg/tpl/service.go Outdated Show resolved Hide resolved
tool/internal_pkg/pluginmode/thriftgo/file_tpl.go Show resolved Hide resolved
tool/internal_pkg/generator/type.go Outdated Show resolved Hide resolved
@HeyJavaBean HeyJavaBean self-requested a review September 25, 2023 07:24
@Lvnszn Lvnszn force-pushed the feature_idl_for_hessian branch 5 times, most recently from 2e15904 to cb7a116 Compare September 25, 2023 12:09
felix021
felix021 previously approved these changes Sep 26, 2023
View reviewed changes
@felix021 felix021 changed the title feature: 支持 hessian IDL 相关脚手架 feature(tool): support scaffold generation for hessian2 Oct 9, 2023
@felix021 felix021 mentioned this pull request Oct 15, 2023
Merged
3 tasks
@felix021 felix021 merged commit 008f748 into cloudwego:develop Oct 16, 2023
17 checks passed
@Lvnszn Lvnszn deleted the feature_idl_for_hessian branch October 16, 2023 06:39
@felix021 felix021 mentioned this pull request Nov 3, 2023
Closed
@Lvnszn Lvnszn mentioned this pull request Nov 16, 2023
Closed
3 tasks
@DMwangnima DMwangnima mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix021 felix021 felix021 approved these changes

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

@jasondeng1997 jasondeng1997 jasondeng1997 approved these changes

Assignees

@felix021 felix021

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lvnszn @felix021 @HeyJavaBean @jasondeng1997