Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(limit): support updating config for rate limit dynamically #1083

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

whalecold
Copy link
Member

@whalecold whalecold commented Aug 23, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

支持限流的动态更新

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@whalecold whalecold requested review from a team as code owners August 23, 2023 12:50
@felix021 felix021 self-assigned this Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.05% ⚠️

Comparison is base (22c3087) 69.00% compared to head (ac6a51d) 68.95%.

❗ Current head ac6a51d differs from pull request most recent head 7b31e86. Consider uploading reports for the commit 7b31e86 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1083      +/-   ##
===========================================
- Coverage    69.00%   68.95%   -0.05%     
===========================================
  Files          252      252              
  Lines        18824    18827       +3     
===========================================
- Hits         12990    12983       -7     
- Misses        4659     4668       +9     
- Partials      1175     1176       +1     
Files Changed Coverage Δ
pkg/limiter/qps_limiter.go 50.00% <0.00%> (-1.43%) ⬇️
pkg/limiter/connection_limiter.go 87.50% <100.00%> (+0.83%) ⬆️
server/server.go 86.15% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

felix021
felix021 previously approved these changes Aug 23, 2023
jayantxie
jayantxie previously approved these changes Aug 24, 2023
jayantxie
jayantxie previously approved these changes Aug 24, 2023
felix021
felix021 previously approved these changes Aug 24, 2023
@whalecold whalecold dismissed stale reviews from felix021 and jayantxie via 7b31e86 August 24, 2023 09:07
@felix021 felix021 merged commit 0068e34 into cloudwego:develop Aug 25, 2023
16 checks passed
@whalecold whalecold changed the title feat(limit): support update limit config dynamically feat(limit): support updateing config for rate limit dynamically Aug 31, 2023
@whalecold whalecold changed the title feat(limit): support updateing config for rate limit dynamically feat(limit): support updating config for rate limit dynamically Aug 31, 2023
@whalecold whalecold deleted the feat/limit branch August 31, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants