Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generic): support conversion from string to int and float for json generic to be consistent with the original json generic #1090

Merged

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners August 28, 2023 08:43
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (f548715) 68.96% compared to head (8cf99a0) 68.97%.

❗ Current head 8cf99a0 differs from pull request most recent head f774b44. Consider uploading reports for the commit f774b44 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1090      +/-   ##
===========================================
+ Coverage    68.96%   68.97%   +0.01%     
===========================================
  Files          252      252              
  Lines        18831    18831              
===========================================
+ Hits         12987    12989       +2     
+ Misses        4669     4668       -1     
+ Partials      1175     1174       -1     
Files Changed Coverage Δ
pkg/generic/option.go 100.00% <ø> (ø)
pkg/generic/json_test/generic_init.go 57.37% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsterDY AsterDY merged commit f9373f9 into cloudwego:develop Aug 30, 2023
16 checks passed
@Marina-Sakai Marina-Sakai deleted the fix/json_generic_string2int64 branch August 30, 2023 13:22
@Marina-Sakai Marina-Sakai changed the title fix: support conversion from string to int and float for json generic to be consistent with the original json generic fix(generic): support conversion from string to int and float for json generic to be consistent with the original json generic Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants