Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable frugal on go1.21 #1100

Merged
merged 1 commit into from Sep 7, 2023

Conversation

felix021
Copy link
Contributor

@felix021 felix021 commented Sep 7, 2023

What type of PR is this?

chore: Changes to the build process or auxiliary tools and libraries such as documentation generation

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: since kitex v0.7.0, frugal is disabled when compiled on go1.21; now we can remove the restriction with frugal updated to v0.1.8
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners September 7, 2023 06:45
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04% 🎉

Comparison is base (d910b15) 67.91% compared to head (abd1468) 67.96%.

❗ Current head abd1468 differs from pull request most recent head 672df5f. Consider uploading reports for the commit 672df5f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1100      +/-   ##
===========================================
+ Coverage    67.91%   67.96%   +0.04%     
===========================================
  Files          253      253              
  Lines        19131    19131              
===========================================
+ Hits         12993    13002       +9     
+ Misses        4951     4944       -7     
+ Partials      1187     1185       -2     
Files Changed Coverage Δ
pkg/remote/codec/thrift/thrift_frugal_amd64.go 79.48% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felix021 felix021 changed the title fix: enable frugal on go1.21 chore: enable frugal on go1.21 Sep 7, 2023
@felix021 felix021 merged commit 96dd032 into cloudwego:develop Sep 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants