Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generic): the issue of structs cache of generic call has dirty data under multiple services scene #1126

Merged
merged 1 commit into from Nov 17, 2023

Conversation

jayantxie
Copy link
Member

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(generic): 修复多service场景下泛化调用structs cache存在脏数据问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners September 27, 2023 08:56
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d3741d4) 68.07% compared to head (1ed7fd4) 68.11%.
Report is 1 commits behind head on develop.

❗ Current head 1ed7fd4 differs from pull request most recent head 45da0dd. Consider uploading reports for the commit 45da0dd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
+ Coverage    68.07%   68.11%   +0.03%     
===========================================
  Files          254      254              
  Lines        19270    19264       -6     
===========================================
+ Hits         13118    13121       +3     
+ Misses        4973     4964       -9     
  Partials      1179     1179              
Files Coverage Δ
pkg/generic/json_test/generic_init.go 58.73% <100.00%> (+0.44%) ⬆️
pkg/generic/thrift/parse.go 69.80% <100.00%> (-0.51%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jayantxie jayantxie merged commit 9dd9a95 into develop Nov 17, 2023
31 of 32 checks passed
@jayantxie jayantxie deleted the fix/generic_cache_conflict branch November 17, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants