Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the issue of importing additional context packages when generating stream interfaces in kitex. #1137

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

ahaostudy
Copy link
Member

@ahaostudy ahaostudy commented Oct 1, 2023

…ream interface

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ahaostudy ahaostudy requested review from a team as code owners October 1, 2023 05:02
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7781d8a) 68.05% compared to head (ceebce5) 68.04%.
Report is 1 commits behind head on develop.

❗ Current head ceebce5 differs from pull request most recent head 98f58a2. Consider uploading reports for the commit 98f58a2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1137      +/-   ##
===========================================
- Coverage    68.05%   68.04%   -0.02%     
===========================================
  Files          254      254              
  Lines        19270    19270              
===========================================
- Hits         13115    13112       -3     
- Misses        4976     4980       +4     
+ Partials      1179     1178       -1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jayantxie jayantxie merged commit dedd349 into cloudwego:develop Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants