Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: avoid port conflict #1177

Merged
merged 1 commit into from Nov 21, 2023

Conversation

felix021
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: many tests are using the same port 8121, but go will run tests in parallel, which often results in port conflict.
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners November 21, 2023 03:16
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed2f1fd) 68.16% compared to head (fdf6e42) 68.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1177      +/-   ##
===========================================
- Coverage    68.16%   68.13%   -0.04%     
===========================================
  Files          255      255              
  Lines        19395    19395              
===========================================
- Hits         13220    13214       -6     
- Misses        4977     4988      +11     
+ Partials      1198     1193       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsterDY
Copy link
Contributor

AsterDY commented Nov 21, 2023

人工去重容易漏,不如搞个工具函数全局分发一下address?

auto-merge was automatically disabled November 21, 2023 03:29

Base branch was modified

@felix021
Copy link
Contributor Author

人工去重容易漏,不如搞个工具函数全局分发一下address?

下次吧 :D

@felix021 felix021 merged commit f229470 into cloudwego:develop Nov 21, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants