Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(kitexutil): add GetCallerIP util method in kitexutil to fetch Caller IP #1197

Merged

Conversation

YangruiEmma
Copy link
Member

@YangruiEmma YangruiEmma commented Dec 6, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

zh: optimize(kitexutil): kitexutil 添加 GetCallerIP util 方法获取调用方的 IP

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@YangruiEmma YangruiEmma requested review from a team as code owners December 6, 2023 14:46
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (365c91a) 66.55% compared to head (2e0c7f3) 66.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1197      +/-   ##
===========================================
+ Coverage    66.55%   66.63%   +0.08%     
===========================================
  Files          256      256              
  Lines        19453    19464      +11     
===========================================
+ Hits         12946    12969      +23     
+ Misses        5339     5331       -8     
+ Partials      1168     1164       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ppzqh
ppzqh previously approved these changes Dec 7, 2023
joway
joway previously approved these changes Dec 7, 2023
@YangruiEmma YangruiEmma dismissed stale reviews from joway and ppzqh via 0714523 December 7, 2023 03:12
felix021
felix021 previously approved these changes Dec 7, 2023
@YangruiEmma YangruiEmma merged commit fa05fa2 into cloudwego:develop Dec 7, 2023
20 checks passed
joway pushed a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants