Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade golang.org/x/net #1252

Merged
merged 1 commit into from Feb 20, 2024

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Feb 19, 2024

What type of PR is this?

chore

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

zh: chore: 升级 golang.org/x/net

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: This upgrade requires minimal go version to be 1.17.
zh(optional): 该升级要求最低go版本为 1.17。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ppzqh ppzqh requested review from a team as code owners February 19, 2024 12:04
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c063ba) 68.52% compared to head (d5b4cfa) 68.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1252      +/-   ##
===========================================
+ Coverage    68.52%   68.59%   +0.07%     
===========================================
  Files          285      285              
  Lines        20708    20708              
===========================================
+ Hits         14190    14205      +15     
+ Misses        5328     5317      -11     
+ Partials      1190     1186       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

YangruiEmma
YangruiEmma previously approved these changes Feb 19, 2024
@GuangmingLuo
Copy link
Member

requires sonic 1.11.0 to support go 1.22

@ppzqh ppzqh merged commit 25ea7cf into cloudwego:develop Feb 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants