Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): set service/method name into rpcinfo before OnReadStream #1264

Conversation

felix021
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: OnReadStream was called before setting service/method name into rpcinfo.
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners February 27, 2024 07:16
@felix021 felix021 force-pushed the fix/on-read-stream-missing-service-method-name branch from 82f6178 to c54f5db Compare February 27, 2024 07:22
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.55%. Comparing base (d36f79e) to head (a4f7e13).

Files Patch % Lines
pkg/remote/trans/nphttp2/server_handler.go 47.05% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1264      +/-   ##
===========================================
+ Coverage    68.48%   68.55%   +0.06%     
===========================================
  Files          285      285              
  Lines        20646    20646              
===========================================
+ Hits         14140    14153      +13     
+ Misses        5323     5313      -10     
+ Partials      1183     1180       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felix021 felix021 changed the title fix: set service/method name into rpcinfo before OnReadStream fix(grpc): set service/method name into rpcinfo before OnReadStream Feb 27, 2024
@felix021 felix021 merged commit 70b6cf1 into cloudwego:develop Mar 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants