Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: service inline adapt v0.9.0 #1278

Merged
merged 7 commits into from
Mar 14, 2024

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Mar 7, 2024

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

合并编译适配 kitex v0.9.0

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Decouple the client and server, and when dependency isolation is needed, Kitex can transition from partial isolation to complete isolation. In order to achieve this, the service inline client only passes the necessary rpcinfo and other metadata to the server. After constructing the server rpcinfo and server ctx based on the client rpcinfo on the server side, the merged compilation call is completed.
zh(optional): 将 client 和 server 解耦,依赖隔离的时候 kitex 可以由原来的部分隔离变成全部隔离。为了达到这个目的, service inline client 只将必要的 rpcinfo 和其他元数据传递给 server,在 server 侧根据 client rpcinfo 构建出 server rpcinfo 和 server ctx 后完成合并编译调用。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Duslia Duslia requested review from a team as code owners March 7, 2024 07:55
@Duslia Duslia force-pushed the feat/service_inline_adapt_1.15 branch 4 times, most recently from 6ee28d4 to 97f9c67 Compare March 8, 2024 02:44
@Duslia Duslia force-pushed the feat/service_inline_adapt_1.15 branch 3 times, most recently from 52f9816 to 77431f8 Compare March 10, 2024 01:14
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 70.30%. Comparing base (8c6242b) to head (cab9fe1).

Files Patch % Lines
server/service_inline.go 90.00% 4 Missing and 2 partials ⚠️
client/service_inline.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1278      +/-   ##
===========================================
+ Coverage    70.24%   70.30%   +0.05%     
===========================================
  Files          287      288       +1     
  Lines        20921    20929       +8     
===========================================
+ Hits         14697    14715      +18     
+ Misses        5003     4996       -7     
+ Partials      1221     1218       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Duslia Duslia force-pushed the feat/service_inline_adapt_1.15 branch 2 times, most recently from e652b08 to 1142e57 Compare March 11, 2024 03:45
@wzekin wzekin force-pushed the feat/service_inline_adapt_1.15 branch 5 times, most recently from aadb68f to 5d3731c Compare March 11, 2024 07:46
@Duslia Duslia changed the title [WIP] feat: service inline adapt 1.15 feat: service inline adapt 1.15 Mar 11, 2024
@Duslia Duslia force-pushed the feat/service_inline_adapt_1.15 branch from 3f72458 to ba5177d Compare March 11, 2024 09:50
@Duslia Duslia force-pushed the feat/service_inline_adapt_1.15 branch 6 times, most recently from 32c83b1 to 5393f83 Compare March 14, 2024 08:57
@Duslia Duslia force-pushed the feat/service_inline_adapt_1.15 branch from 5393f83 to cab9fe1 Compare March 14, 2024 11:00
@YangruiEmma YangruiEmma merged commit b539bda into cloudwego:develop Mar 14, 2024
22 checks passed
@Duslia Duslia changed the title feat: service inline adapt 1.15 feat: service inline adapt v0.9.0 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants