Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): client stream recv returning io.EOF is not error #1279

Merged

Conversation

felix021
Copy link
Contributor

@felix021 felix021 commented Mar 7, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix: Client stream recv 返回 io.EOF 不应被记为 error

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners March 7, 2024 07:57
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.56%. Comparing base (a4a1cc9) to head (5869f55).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1279      +/-   ##
===========================================
+ Coverage    68.49%   68.56%   +0.07%     
===========================================
  Files          285      285              
  Lines        20643    20643              
===========================================
+ Hits         14139    14154      +15     
+ Misses        5321     5310      -11     
+ Partials      1183     1179       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felix021 felix021 force-pushed the fix/client-stream-recv-eof-not-error branch from 8955839 to d07ffa1 Compare March 7, 2024 10:05
@felix021 felix021 force-pushed the fix/client-stream-recv-eof-not-error branch from d07ffa1 to 5869f55 Compare March 7, 2024 10:06
@felix021 felix021 changed the title fix: client stream recv returning io.EOF is not error fix(grpc): client stream recv returning io.EOF is not error Mar 7, 2024
@felix021 felix021 merged commit b4906e4 into cloudwego:develop Mar 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants