Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code_gen client stream should import WithDoFinish #1280

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

felix021
Copy link
Contributor

@felix021 felix021 commented Mar 7, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix: 生成代码里的 Client Stream 应当实现 WithDoFinish 接口

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: The client stream in codegen is another Stream wrapper, which leads to failure when performing type assertion in streaming.FinishStream(st, err)
zh(optional): 生成代码里的 Client Stream 对 Stream 多做了一层封装,因此在 streaming.FinishStream(st, err) 里做 type assertion 会失败。

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners March 7, 2024 12:40
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.49%. Comparing base (b4906e4) to head (e2fe9fb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1280      +/-   ##
===========================================
- Coverage    68.53%   68.49%   -0.04%     
===========================================
  Files          285      285              
  Lines        20643    20643              
===========================================
- Hits         14147    14140       -7     
- Misses        5315     5322       +7     
  Partials      1181     1181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felix021 felix021 merged commit 8702d7e into cloudwego:develop Mar 8, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants