Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streaming): not reporting BizStatusError to tracer #1283

Merged

Conversation

felix021
Copy link
Contributor

@felix021 felix021 commented Mar 8, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix: 不要把 BizStatusError 直接报给 tracer

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: BizStatusError is not an RPC error; tracer should read it from RPCInfo.
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners March 8, 2024 13:07
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (92f64b0) to head (86284dd).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1283      +/-   ##
===========================================
- Coverage    70.21%   70.19%   -0.02%     
===========================================
  Files          287      287              
  Lines        20744    20751       +7     
===========================================
+ Hits         14565    14567       +2     
  Misses        4978     4978              
- Partials      1201     1206       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felix021 felix021 force-pushed the fix/not-reporting-biz-err-to-tracer branch 2 times, most recently from c12204c to 3161e1a Compare March 14, 2024 02:49
jayantxie
jayantxie previously approved these changes Mar 14, 2024
@felix021 felix021 merged commit 4ef349b into cloudwego:develop Mar 14, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants