Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix TestMain forget to call m.Run in pkg/utils #1288

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

joway
Copy link
Member

@joway joway commented Mar 11, 2024

What type of PR is this?

chore

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

chore: 修复 TestMain 忘记调用 m.Run 的问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners March 11, 2024 05:22
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (6967747) to head (74d2533).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1288      +/-   ##
===========================================
+ Coverage    68.49%   70.09%   +1.59%     
===========================================
  Files          285      286       +1     
  Lines        20643    20676      +33     
===========================================
+ Hits         14140    14492     +352     
+ Misses        5321     4978     -343     
- Partials      1182     1206      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joway joway changed the title chore: fix TestMain forget to call m.Run chore: fix TestMain forget to call m.Run in pkg/utils Mar 11, 2024
@joway joway merged commit 890b56a into cloudwego:develop Mar 11, 2024
22 checks passed
@joway joway deleted the chore/fix-testmain branch March 11, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants