Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dynamicgo to v0.2.9 #1395

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

Zzhiter
Copy link
Contributor

@Zzhiter Zzhiter commented Jun 18, 2024

What type of PR is this?

chore: update dynamicgo to v0.2.9

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

前段时间, 有用户在使用 kitexcall 的过程中,在发现了kitex泛化调用的一个bug: https://github.com/a631807682/kitexcall-issue ,最终溯源到这个bug是由于dynamicgo引起的。

昨天 dynamicgo 已经修复这个问题:cloudwego/dynamicgo#57
并且发布了新的release:https://github.com/cloudwego/dynamicgo/releases/tag/v0.2.9
今天早上已经验证过这个问题已经被修复。

kitexcall强依赖于kitex,kitex需要同步升级一下dynamicgo版本。

@Zzhiter Zzhiter requested review from a team as code owners June 18, 2024 05:05
@Zzhiter
Copy link
Contributor Author

Zzhiter commented Jun 18, 2024

Unit test failed, need check

@ppzqh ppzqh assigned AsterDY and ppzqh and unassigned ppzqh Jun 26, 2024
@khan-yin
Copy link

khan-yin commented Jun 27, 2024

Unit test failed, need check
@Zzhiter @AsterDY
the example2.proto and bin data need to update in kitex: pkg/generic/jsonpb_test/idl/example2.proto
I changed the example2.proto and bin data in dynamicgo for sint test convertion. https://github.com/cloudwego/dynamicgo/pull/57
details:
image
image

@Zzhiter
Copy link
Contributor Author

Zzhiter commented Jun 27, 2024

@khan-yin Thank you! fixed.

@Zzhiter
Copy link
Contributor Author

Zzhiter commented Jun 28, 2024

When I update example2.proto, the relevant UT using this file also failed, so I update them too.

@AsterDY AsterDY merged commit 573dc2b into cloudwego:develop Jul 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants