Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and improve the use of lock #203

Merged
merged 3 commits into from
Nov 17, 2021
Merged

fix and improve the use of lock #203

merged 3 commits into from
Nov 17, 2021

Conversation

liu-song
Copy link
Contributor

@liu-song liu-song commented Nov 9, 2021 •
edited

Write operation uses write lock to avoid race , and read operation uses read lock

@simon0-o
Copy link
Member

image
In Line70 there is a edit to q.ring, maybe we should use q.mu.Lock() and q.mu.Unlock().

@GuangmingLuo
Copy link
Member

Please add some information in the PR description (or next time) so that others can understand easily what you did in this PR.

@liu-song
Copy link
Contributor Author

Please add some information in the PR description (or next time) so that others can understand easily what you did in this PR.

ok ,I will add more informations about PR.

@YangruiEmma YangruiEmma merged commit ce9e9ee into cloudwego:develop Nov 17, 2021
@liu-song liu-song mentioned this pull request Jan 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@joway joway joway approved these changes

@simon0-o simon0-o simon0-o approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liu-song @simon0-o @GuangmingLuo @YangruiEmma @joway