Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:update typos version and fix typos #304

Merged
merged 5 commits into from
Jan 5, 2022
Merged

chore:update typos version and fix typos #304

merged 5 commits into from
Jan 5, 2022

Conversation

liu-song
Copy link
Contributor

What type of PR is this?

fix typos

What this PR does / why we need it (English/Chinese):

EN:fix typos
CN:升级typos action 的版本,修复相关的typos

Which issue(s) this PR fixes:

@liu-song
Copy link
Contributor Author

image

在我fork 的仓库通过这个test,这个是偶现的?

@liu-song
Copy link
Contributor Author

liu-song commented Jan 5, 2022

单元测试中出现的这些panic和error 需要修复吗,还是为了测试这些场景?
image

@YangruiEmma
Copy link
Member

单元测试中出现的这些panic和error 需要修复吗,还是为了测试这些场景? image

这些都是mock的异常,只要测试是通过的即可

Copy link
Member

@YangruiEmma YangruiEmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangruiEmma YangruiEmma merged commit 3f2359c into cloudwego:develop Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants