refactor(loadbalancer): merge function buildWeightedVirtualNodes into buildVirtualNodes #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
li-jin-gou
reviewed
Feb 13, 2022
f20500909
commented
Feb 14, 2022
PureWhiteWu
requested changes
Feb 16, 2022
added 3 commits
February 16, 2022 23:48
PureWhiteWu
approved these changes
Mar 18, 2022
lsjbd
approved these changes
Mar 18, 2022
YangruiEmma
approved these changes
Mar 18, 2022
lsjbd
added a commit
that referenced
this pull request
Mar 24, 2022
* define not found instance error. * define ErrInstanceNotFound at kerrors. * tuning err msg for no instance. * refactor:replace additional atomic operations * fix:solving the concurrency problem of Hooks. * optimize: adjust minMaxIdleTimeout to 2s * optimize: lbcache is global, it doesn't need register ProbeFunc for diagnosis * docs: update readme with new blog * chore:upgrade choleraehyq/pid for Go 1.18 * fix(client): fix oneway seqid and lower loss rate (#363) * optimize: use instance tag instead of remoteinfo tag firstly (#374) * fix: combine services (#367) * fix(tool): fix import of protobuf combineservice (#359) * refactor(loadbalancer): merge function buildWeightedVirtualNodes into buildVirtualNodes (#343) * refactor(loadbalancer): merge function buildWeightedVirtualNodes into buildVirtualNodes * Fix readme blog link * fix(generic): detect circular thrift IDL dependency (#383) * chore: update version v0.2.1 Co-authored-by: horizonzy <horizonzy@apache.org> Co-authored-by: dongzeXD <l65775622@gmail.com> Co-authored-by: dongze <43315356+dongzeXD@users.noreply.github.com> Co-authored-by: YangruiEmma <yangr.emma@gmail.com> Co-authored-by: Joway <wangzhuowei@bytedance.com> Co-authored-by: luoguangming.ivan <luoguangming.ivan@bytedance.com> Co-authored-by: YangruiEmma <yangrui.emma@bytedance.com> Co-authored-by: HeyJavaBean <imlehr@163.com> Co-authored-by: lsjbd <44455379+lsjbd@users.noreply.github.com> Co-authored-by: Anthony-Dong <fanhaodong516@gmail.com> Co-authored-by: Simon Wang <jellalleonhardt4869@gmail.com> Co-authored-by: 王恒 <33808231+f20500909@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
What this PR does / why we need it (English/Chinese):
EN: Merge BuildWeightedVirtualNodes function into buildVirtualNodes function, become one big function. Delete duplicate code, make it easier to maintain and enhance.
ZH：将buildWeightedVirtualNodes 函数合入buildVirtualNodes函数中，成为一个函数。因为两者的重复代码太多，不利于后续维护。
Which issue(s) this PR fixes:
None