Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tool): add an argument for thriftgo plugin time limit #708

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

simon0-o
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

增加参数指定 thriftgo 插件执行时间限制

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: add an argument to configure max execution time for thriftgo plugin
zh(optional): 增加一个参数用于指定 thriftgo 插件最大执行时间

Which issue(s) this PR fixes:

none

HeyJavaBean
HeyJavaBean previously approved these changes Nov 10, 2022
YangruiEmma
YangruiEmma previously approved these changes Nov 10, 2022
@simon0-o simon0-o force-pushed the feat/thriftgo_global_parameter branch from 00151b6 to 10b4253 Compare November 10, 2022 14:02
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 69.15% // Head: 69.25% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (10b4253) compared to base (5506a46).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #708      +/-   ##
===========================================
+ Coverage    69.15%   69.25%   +0.10%     
===========================================
  Files          231      231              
  Lines        17126    17126              
===========================================
+ Hits         11843    11861      +18     
+ Misses        4186     4167      -19     
- Partials      1097     1098       +1     
Impacted Files Coverage Δ
pkg/remote/connpool/long_pool.go 95.50% <33.33%> (-1.00%) ⬇️
pkg/warmup/pool_helper.go 93.75% <0.00%> (-2.09%) ⬇️
pkg/remote/trans/nphttp2/grpc/controlbuf.go 83.22% <0.00%> (-0.89%) ⬇️
pkg/remote/trans/nphttp2/grpc/http2_server.go 71.38% <0.00%> (+0.47%) ⬆️
pkg/remote/trans/netpollmux/server_handler.go 71.31% <0.00%> (+0.79%) ⬆️
pkg/remote/trans/nphttp2/grpc/http2_client.go 74.06% <0.00%> (+1.40%) ⬆️
pkg/profiler/profiler.go 73.61% <0.00%> (+1.84%) ⬆️
pkg/remote/trans/nphttp2/conn_pool.go 79.79% <0.00%> (+2.02%) ⬆️
...emote/trans/nphttp2/grpc/grpcframe/frame_reader.go 48.46% <0.00%> (+2.45%) ⬆️
pkg/remote/trans/netpollmux/mux_conn.go 70.00% <0.00%> (+4.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simon0-o simon0-o merged commit 146634e into cloudwego:develop Nov 11, 2022
@simon0-o simon0-o deleted the feat/thriftgo_global_parameter branch November 11, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants