Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tool): the import did not use the new method to render when template append content #787

Merged
merged 1 commit into from Jan 16, 2023

Conversation

Duslia
Copy link
Member

@Duslia Duslia commented Jan 16, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

当模板增量更新时,import 未使用新增的 method 渲染

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: the import did not use the new method to render when template
zh(optional): 当模板增量更新时,import 未使用新增的 method 渲染

Which issue(s) this PR fixes:

@Duslia Duslia requested review from a team as code owners January 16, 2023 09:58
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 69.63% // Head: 69.68% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (6b8c3e9) compared to base (c3068d4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #787      +/-   ##
===========================================
+ Coverage    69.63%   69.68%   +0.04%     
===========================================
  Files          232      232              
  Lines        17258    17258              
===========================================
+ Hits         12018    12026       +8     
+ Misses        4148     4143       -5     
+ Partials      1092     1089       -3     
Impacted Files Coverage Δ
pkg/remote/trans/nphttp2/grpc/http2_client.go 73.90% <0.00%> (+0.15%) ⬆️
pkg/remote/trans/nphttp2/grpc/http2_server.go 71.38% <0.00%> (+0.47%) ⬆️
pkg/remote/codec/default_codec.go 74.34% <0.00%> (+2.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jin-gou li-jin-gou merged commit da3b1d7 into cloudwego:develop Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants