Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tool): support codegen in windows #881

Merged
merged 1 commit into from Mar 31, 2023

Conversation

HeyJavaBean
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.

(Optional) Translate the PR title into Chinese.

feat(tool): 支持 windows 场景下的代码生成

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

Which issue(s) this PR fixes:

@HeyJavaBean HeyJavaBean requested review from a team as code owners March 29, 2023 12:15
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (3ba21f5) 69.01% compared to head (2f2f8ed) 68.93%.

❗ Current head 2f2f8ed differs from pull request most recent head a45d75c. Consider uploading reports for the commit a45d75c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #881      +/-   ##
===========================================
- Coverage    69.01%   68.93%   -0.09%     
===========================================
  Files          238      238              
  Lines        17811    17812       +1     
===========================================
- Hits         12293    12278      -15     
- Misses        4410     4424      +14     
- Partials      1108     1110       +2     
Impacted Files Coverage Δ
pkg/rpcinfo/remoteinfo/remoteInfo.go 87.87% <100.00%> (+0.12%) ⬆️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HeyJavaBean HeyJavaBean force-pushed the feat/tool_windows branch 2 times, most recently from a7e8359 to 795815d Compare March 30, 2023 06:38
Duslia
Duslia previously approved these changes Mar 30, 2023
YangruiEmma
YangruiEmma previously approved these changes Mar 31, 2023
go.mod Outdated Show resolved Hide resolved
@HeyJavaBean HeyJavaBean merged commit 164d3a2 into cloudwego:develop Mar 31, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants