Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(generic): add thrift reflection (using dynamicgo) generic call example #900

Merged
merged 18 commits into from May 25, 2023

Conversation

AsterDY
Copy link
Contributor

@AsterDY AsterDY commented Apr 13, 2023

What type of PR is this?

test

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: add thrift reflection (using dynamicgo) generic call example
zh(optional): 添加 thrift 反射方式的泛化调用用例

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@AsterDY AsterDY requested review from a team as code owners April 13, 2023 10:30
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (cde0e46) 68.95% compared to head (b0d47b2) 68.93%.

❗ Current head b0d47b2 differs from pull request most recent head e7a4435. Consider uploading reports for the commit e7a4435 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #900      +/-   ##
===========================================
- Coverage    68.95%   68.93%   -0.03%     
===========================================
  Files          244      244              
  Lines        17937    17937              
===========================================
- Hits         12368    12364       -4     
- Misses        4457     4460       +3     
- Partials      1112     1113       +1     
Impacted Files Coverage Δ
pkg/rpctimeout/item_rpc_timeout.go 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@YangruiEmma
Copy link
Member

pr tiltle fmt is test(generic):

@AsterDY AsterDY changed the title test:(generic) add thrift reflection (using dynamicgo) generic call example test(generic): add thrift reflection (using dynamicgo) generic call example Apr 27, 2023
@AsterDY
Copy link
Contributor Author

AsterDY commented Apr 27, 2023

pr tiltle fmt is test(generic):

do, please review @YangruiEmma

@YangruiEmma YangruiEmma merged commit 2f4d3b4 into cloudwego:develop May 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants