Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mux): fix the problem that output unreasonable error when exit if enable mux and use Kitex Protobuf #922

Merged
merged 2 commits into from May 11, 2023

Conversation

YangruiEmma
Copy link
Member

@YangruiEmma YangruiEmma commented May 4, 2023

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(mux): 修复当开启 mux 并且使用 Kitex Protobuf 时,在退出时输出不合理的 error 问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Fixes #894

(optional) The PR that updates user documentation:

@YangruiEmma YangruiEmma requested review from a team as code owners May 4, 2023 09:27
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (dcabd92) 69.05% compared to head (79a3608) 69.07%.

❗ Current head 79a3608 differs from pull request most recent head 3e56005. Consider uploading reports for the commit 3e56005 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #922      +/-   ##
===========================================
+ Coverage    69.05%   69.07%   +0.01%     
===========================================
  Files          238      238              
  Lines        17828    17828              
===========================================
+ Hits         12312    12314       +2     
+ Misses        4411     4410       -1     
+ Partials      1105     1104       -1     
Impacted Files Coverage Δ
pkg/remote/codec/default_codec.go 75.65% <100.00%> (+1.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

joway
joway previously approved these changes May 4, 2023
jayantxie
jayantxie previously approved these changes May 5, 2023
@YangruiEmma YangruiEmma dismissed stale reviews from jayantxie and joway via 3e56005 May 8, 2023 05:43
@YangruiEmma YangruiEmma merged commit 9fd74e5 into cloudwego:develop May 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

「KITEX: signal connection closing error: protobuf just support 'framed' trans proto」警告问题
3 participants