Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add config items for retry/cb/rcptimeout/limiter #936

Merged
merged 1 commit into from May 24, 2023

Conversation

felix021
Copy link
Contributor

What type of PR is this?

feat(config): A new feature

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

增加 重试、熔断、超时、限流 的 config item

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: for better integration with external config center
zh(optional): 重用于支持与外部配置中心的集成

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@felix021 felix021 requested review from a team as code owners May 16, 2023 12:24
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 11.76% and project coverage change: -0.36 ⚠️

Comparison is base (add948b) 69.32% compared to head (3152d93) 68.96%.

❗ Current head 3152d93 differs from pull request most recent head b45f8c7. Consider uploading reports for the commit b45f8c7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #936      +/-   ##
===========================================
- Coverage    69.32%   68.96%   -0.36%     
===========================================
  Files          240      244       +4     
  Lines        17887    17940      +53     
===========================================
- Hits         12400    12373      -27     
- Misses        4379     4453      +74     
- Partials      1108     1114       +6     
Impacted Files Coverage Δ
pkg/circuitbreak/item_circuit_breaker.go 0.00% <0.00%> (ø)
pkg/limiter/item_limiter.go 0.00% <0.00%> (ø)
pkg/remote/trans/netpollmux/server_handler.go 68.87% <0.00%> (-0.78%) ⬇️
pkg/retry/item_retry.go 0.00% <0.00%> (ø)
pkg/rpctimeout/item_rpc_timeout.go 0.00% <0.00%> (ø)
pkg/remote/trans/netpollmux/mux_conn.go 63.88% <100.00%> (-4.61%) ⬇️
pkg/remote/trans/netpollmux/mux_pool.go 90.16% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felix021 felix021 force-pushed the feat/config-value-items branch 2 times, most recently from e4ba551 to d17c53f Compare May 17, 2023 12:18
@jayantxie jayantxie closed this May 18, 2023
@jayantxie jayantxie reopened this May 18, 2023
go.mod Outdated Show resolved Hide resolved
@felix021 felix021 force-pushed the feat/config-value-items branch 2 times, most recently from ae9eb31 to 441cdea Compare May 24, 2023 03:07
@felix021 felix021 merged commit 0fbf5a2 into cloudwego:develop May 24, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants