Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: dont return error when transHandler not implement graceful shutdown #954

Merged
merged 1 commit into from
May 30, 2023

Conversation

joway
Copy link
Member

@joway joway commented May 30, 2023

What type of PR is this?

optimize

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

optimize: 当 transHandler 没有实现 GracefulShutdown 接口时,不返回报错

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners May 30, 2023 05:45
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (51e728f) 68.94% compared to head (aa41bdf) 68.96%.

❗ Current head aa41bdf differs from pull request most recent head df3626c. Consider uploading reports for the commit df3626c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #954      +/-   ##
===========================================
+ Coverage    68.94%   68.96%   +0.02%     
===========================================
  Files          244      244              
  Lines        17937    17937              
===========================================
+ Hits         12366    12371       +5     
+ Misses        4458     4452       -6     
- Partials      1113     1114       +1     
Impacted Files Coverage Δ
pkg/remote/trans_pipeline.go 79.66% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joway joway merged commit 2651dc4 into cloudwego:develop May 30, 2023
15 of 16 checks passed
@joway joway deleted the fix/graceful branch May 30, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants