Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poller read all data before connection close #226

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

joway
Copy link
Member

@joway joway commented Dec 21, 2022

What type of PR is this?

chore

What this PR does / why we need it (en: English/zh: Chinese):

en: fix: poller read all data before connection close
zh: fix: poller 在连接关闭之前,尝试读取完所有数据

Which issue(s) this PR fixes:

@joway joway requested review from a team as code owners December 21, 2022 08:22
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 62 files.

Valid Invalid Ignored Fixed
55 1 6 0
Click to see the invalid file list
  • poll_default.go

poll_default.go Outdated Show resolved Hide resolved
@joway joway force-pushed the fix/server-close-v2 branch 5 times, most recently from 6c01ce3 to 19c7ede Compare December 21, 2022 08:42
@joway joway force-pushed the fix/server-close-v2 branch 2 times, most recently from de9a7be to acd5e1b Compare February 16, 2023 07:15
@joway joway force-pushed the fix/server-close-v2 branch 2 times, most recently from 00f72a0 to 2206ca1 Compare February 28, 2023 05:28
poll_default.go Outdated Show resolved Hide resolved
@joway joway enabled auto-merge (squash) February 28, 2023 12:06
@ppzqh ppzqh self-requested a review March 1, 2023 02:44
@joway joway requested a review from a team March 1, 2023 06:51
@joway joway disabled auto-merge March 1, 2023 06:52
@joway joway enabled auto-merge (squash) March 1, 2023 06:52
@joway joway merged commit 6704628 into develop Mar 1, 2023
@joway joway deleted the fix/server-close-v2 branch March 1, 2023 06:53
firedtoad pushed a commit to firedtoad/netpoll that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants