Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Detach function to support detach connection from its poller #249

Merged
merged 2 commits into from
May 8, 2023

Conversation

jayantxie
Copy link
Member

@jayantxie jayantxie commented Apr 26, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: 添加Detach函数来支持从连接的poller中删除连接

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners April 26, 2023 12:09
@jayantxie jayantxie changed the title Feat/detach conn feat: add detachPoller function to support detach connection from its poller May 6, 2023
@jayantxie jayantxie force-pushed the feat/detach_conn branch 3 times, most recently from 800c2ce to c5c2a64 Compare May 8, 2023 07:14
connection_impl.go Outdated Show resolved Hide resolved
@jayantxie jayantxie changed the title feat: add detachPoller function to support detach connection from its poller feat: add Detach function to support detach connection from its poller May 8, 2023
@joway joway merged commit 3868013 into cloudwego:develop May 8, 2023
5 of 7 checks passed
firedtoad pushed a commit to firedtoad/netpoll that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants