Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async trait Thrift input protocol #83

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

ii64
Copy link
Member

@ii64 ii64 commented Jan 30, 2023

Motivation

Follow up cloudwego/volo#121

@PureWhiteWu
Copy link
Member

Good job!
非常棒,还有一些 lint 问题修一下就好啦~
你可以直接在本地执行 cargo fmt 来自动 foramt 就行了~

Copy link
Member

@PureWhiteWu PureWhiteWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@LYF1999 @Millione 也来看一眼?

@PureWhiteWu PureWhiteWu force-pushed the feat/async-trait-input-protocol branch from c8ec326 to 9baa4f0 Compare January 31, 2023 07:58
@PureWhiteWu PureWhiteWu merged commit b797a1d into cloudwego:main Feb 1, 2023
@ii64 ii64 deleted the feat/async-trait-input-protocol branch February 1, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants