Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add get annotation func #113

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

Lvnszn
Copy link
Contributor

@Lvnszn Lvnszn commented Aug 10, 2023

Description

add a func which can get annotation value by key and index

Motivation and Context

Related Issue

@Lvnszn Lvnszn requested review from a team as code owners August 10, 2023 02:31
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@Lvnszn Lvnszn force-pushed the feature_idl_gen branch 2 times, most recently from 0e398e7 to 527d016 Compare August 12, 2023 04:02
@Lvnszn Lvnszn changed the title WIP: feature: add func generate in idl feature: add func generate in idl Aug 12, 2023
parser/parser.go Outdated Show resolved Hide resolved
parser/util.go Outdated Show resolved Hide resolved
parser/util_test.go Outdated Show resolved Hide resolved
@HeyJavaBean HeyJavaBean changed the title feature: add func generate in idl WIP: feature: add func generate in idl Aug 14, 2023
@Lvnszn Lvnszn force-pushed the feature_idl_gen branch 3 times, most recently from 7fa1ee2 to 9a0360d Compare August 16, 2023 12:33
@Lvnszn Lvnszn changed the title WIP: feature: add func generate in idl feature: add get annotation func Aug 16, 2023
@HeyJavaBean HeyJavaBean changed the title feature: add get annotation func WIP: feature: add get annotation func Aug 17, 2023
@HeyJavaBean HeyJavaBean changed the title WIP: feature: add get annotation func feat: add get annotation func Aug 28, 2023
@HeyJavaBean HeyJavaBean merged commit edaddf2 into cloudwego:main Aug 28, 2023
2 of 3 checks passed
tksky1 pushed a commit to tksky1/thriftgo that referenced this pull request Oct 5, 2023
@Lvnszn Lvnszn deleted the feature_idl_gen branch November 16, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants