feat: add IDL trimming #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add integration test
# Conflicts: # generator/golang/option.go
|
|
HeyJavaBean
approved these changes
Aug 23, 2023
tksky1
added a commit
to tksky1/thriftgo
that referenced
this pull request
Oct 5, 2023
Co-authored-by: HeyJavaBean <imlehr@163.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a trim tool to remove unused part of IDL and dump the trimmed one;
add -t for thriftgo to pre-trim the IDL before generating go code
Motivation and Context
for many IDLs, a lot of unused fields and included IDLs will also be generated as Go code, even the service use little of them, which can make the generated code unnecessarily big. By adding a way to pre-trim the IDL to remove unused parts for services, or adding an option to trim the IDL before generating the go code, can be helpful to limit the size of generated code.