feat: add @preserve comments to preserve the struct from being trimmed #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: fix some -m bugs
fix: fix some -m bugs
HeyJavaBean
approved these changes
Sep 7, 2023
tksky1
added a commit
to tksky1/thriftgo
that referenced
this pull request
Oct 5, 2023
3 tasks
HeyJavaBean
pushed a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for IDL trimmer, add a way to use comments "@preserve" to preserve struct-likes from being trimmed.
fix some bugs for trimmer tool.
Motivation and Context
users need a way to avoid struct-likes being trimmed for a direct-use of the thrift-gen code, other than using them for rpc. marking @preserve in comments can be an easy way to stop trimmer from deleting the structs.