Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add regexp support for method-based trimming #139

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

tksky1
Copy link
Contributor

@tksky1 tksky1 commented Nov 1, 2023

Description

add regexp support for method-based trimming(-m) of trimmer tool.
now you can use regexp to match methods-to-trim with something like:

  • trimmer -m 'Employee...' test_cases/sample1.thrift
  • trimmer -m '^(?!EmployeeService.getEmployee).*$' test_cases/sample1.thrift

Motivation and Context

some users need to match or unmatch some custom methods-to-trim.

@tksky1 tksky1 requested review from a team as code owners November 1, 2023 11:51
@HeyJavaBean HeyJavaBean merged commit 74820aa into cloudwego:main Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants