fix: streaming support including dot-separated thrift file #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyJavaBean
previously approved these changes
Jan 18, 2024
YangruiEmma
previously approved these changes
Jan 18, 2024
felix021
dismissed stale reviews from YangruiEmma and HeyJavaBean
via
b1d1470
felix021
force-pushed
the
fix/streaming-include-dot-separated-thrift
branch
from
49eb06c
to
b1d1470
Compare
YangruiEmma
approved these changes
Jan 18, 2024
HeyJavaBean
approved these changes
Jan 18, 2024
HeyJavaBean
pushed a commit
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the failure for Thrift Streaming when a thrift file is including another thrift file with name
a.b.c.thrift.Motivation and Context
Related Issue